search

tugh / lean-url

Removes evil URL parameters such as Google Analytics' utm parameters
19 stars 1 forks source link

Lean URL: fix for Nightly and website specific rules #4

Closed Smile4ever closed 7 years ago

Smile4ever commented 7 years ago

Hi,

I've implemented a fix and a feature in this pull request.

It didn't work in Nightly. Adding to the manifest fixed this problem.

Global params like nb@tweakers.net now work if you include "nb@tweakers.net" in the globalBlockedParams array.

Example URL: https://tweakers.net/nieuws/124721/lenovo-brengt-5-inch-moto-c-plus-met-4000mah-accu-begin-juni-uit-voor-119-euro.html?nb=2017-05-17&u=0900

I've implemented this feature so that Lean URL can be compatible with Pure URL rules.

I would be glad if you would accept this code. I've attempted to follow your code style.

tugh commented 7 years ago

Since you've decided to continue the development on your fork I'm rejecting this pull request even though there is nothing wrong.

I will add a url on the readme to your code and extension.