Add `.extensionKitExtension` as the new `PBXProductType`

[mtj0928]

Resolves: https://github.com/tuist/XcodeProj/issues/687

Short description 📝

From Xcode14 beta 1, com.apple.product-type.extensionkit-extension was introduced as the new productType. The new productType is used for a new app extension like AppIntents Extension.

Solution 📦

Added .extensionKitExtension as the new case of PBXProductType in this PR, to support the new productType.

Implementation 👩‍💻👨‍💻

• [x] Added .extensionKitExtension as the new case of PBXProductType
• [x] Added fileExtension of .extensionKitExtension
• [x] Added a new UnitTest for .extensionKitExtension

[kwridan]

@all-contributors add @mtj0928 for code

[allcontributors[bot]]

@kwridan

I've put up a pull request to add @mtj0928! :tada:

[mtj0928]

@kwridan Thank you for your comment!!

I actually considered the name at first , but I also felt it was a bit odd. Would you like me to change the name to extensionKitExtension?

[freddi-kit]

I vote to rename as extensionKitExtension to make naming consistently to others (appExtension, tvExtension)

[kwridan]

cc: @tuist/core - any preference to the naming convention - I could see either option working, consistency vs oddness 😅

[danieleformichelli]

Slightly in favor of extensionKitExtension to make clear it's an extension, but no strong opinion

[fortmarek]

I'm ok with merging this but I am also leaning to use the more consistent extensionKitExtension. While it does sound weird, I prefer it over having to deal with it down the road if we need to differentiate between different types for extensionKit.

[kwridan]

@mtj0928 can we trouble you to rename to .extensionKitExtension?

The points raised by @fortmarek are valid, while the name is odd, it is consistent with other product types and the underlying Xcode types.

[codecov-commenter]

Codecov Report

Merging #691 (ac41122) into main (4dccbc0) will decrease coverage by 0.00%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   84.93%   84.92%   -0.01%     
==========================================
  Files         157      157              
  Lines        9098     9101       +3     
==========================================
+ Hits         7727     7729       +2     
- Misses       1371     1372       +1     

Impacted Files	Coverage Δ
...ces/XcodeProj/Objects/Targets/PBXProductType.swift	54.28% <50.00%> (-1.60%)	:arrow_down:
...rojTests/Objects/Targets/PBXProductTypeTests.swift	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4dccbc0...ac41122. Read the comment docs.

[mtj0928]

Thank you for your discussion, I renamed the new case and pushed the changes😄

[freddi-kit]

Hello, @kwridan, when is it released as new version?

[kwridan]

Let's wait till #694 is merged then we can do a release with a few of the Xcode 14 related items within it.