tuist / XcodeProj

πŸ“ Read, update and write your Xcode projects
https://xcodeproj.tuist.io
MIT License
2.03k stars 309 forks source link

Fix ordering of Scheme toplevel attrs #698

Closed maxwellE closed 2 years ago

maxwellE commented 2 years ago

Fix for incorrect ordering of Scheme attrs when using wasCreatedForAppExtension value

codecov-commenter commented 2 years ago

Codecov Report

Merging #698 (972db0a) into main (e651344) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
+ Coverage   84.93%   84.96%   +0.03%     
==========================================
  Files         157      157              
  Lines        9127     9147      +20     
==========================================
+ Hits         7752     7772      +20     
  Misses       1375     1375              
Impacted Files Coverage Ξ”
...urces/XcodeProj/Extensions/AEXML+XcodeFormat.swift 92.45% <ΓΈ> (ΓΈ)
...eProjTests/Extensions/AEXML+XcodeFormatTests.swift 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update e651344...972db0a. Read the comment docs.

luispadron commented 2 years ago

@maxwellE thanks for the PR. I've merged some of them and looks like that created a conflict here. Once that's resolved we can get this merged!