tuist / XcodeProj

📝 Read, update and write your Xcode projects

https://xcodeproj.tuist.io

MIT License

2.03k stars 309 forks source link

Update Contributing instructions to directly open Package.swift with Xcode #718

Closed michaelmcguire closed 2 years ago

michaelmcguire commented 2 years ago

Short description 📝

While working on #717, I saw the contributing instructions were out-of-date and used the deprecated SPM command generate-xcodeproj. I was able to open, compile and test with Xcode's direct SPM compatibility.

Solution 📦

Update instructions to use Xcode directly.

Implementation 👩‍💻👨‍💻

Updated README.md.

codecov-commenter commented 2 years ago

Codecov Report

Merging #718 (d0461d3) into main (2ad4d41) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files         158      158           
  Lines        9201     9201           
=======================================
  Hits         7806     7806           
  Misses       1395     1395

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

michaelmcguire commented 2 years ago

However, instead of updating the docs in README.md, I suggest linking to this page that goes deeper and uses the now-preferred method of editing tuist with tuist.

@fortmarek Does that make sense for this specific sub-project? I came into this from it's use in bloomberg/xcdiff so I was only interested in opening it up and working with it's tests (not the greater Tuist project).

fortmarek commented 2 years ago

ahh, I'm sorry, yes, for this project it makes complete sense!