🐛 Fix PBXObject Equatable - Githubissues

tuist / XcodeProj

📝 Read, update and write your Xcode projects

https://xcodeproj.tuist.io

MIT License

2.03k stars 309 forks source link

🐛 Fix PBXObject Equatable #736

Closed vguerci closed 1 year ago

vguerci commented 1 year ago

Resolves https://github.com/tuist/xcodeproj/issues/YYY

Short description 📝

PBXObject isEqual, always returning true, doesn't respect Swift Hashable's requirements. That leads to weird/flaky issues like https://github.com/yonaskolb/XcodeGen/issues/1131

Solution 📦

Make sure == is consistent with hash, i.e. same hashValue implying isEqual being true

Implementation 👩‍💻👨‍💻

[X] Check how other isEqual methods are implemented for consistency across the project
[X] Implement it according to the hash() method, i.e. reference is what needs to be equal

vguerci commented 1 year ago

Ah damn, that doesn't pass tests, this needs more work ;p Closing, will reopen when solved.