tuist / XcodeProj

📝 Read, update and write your Xcode projects
https://xcodeproj.tuist.io
MIT License
2.03k stars 309 forks source link

Add support for Xcode Runtime issue breakpoints #761

Closed zenangst closed 1 year ago

zenangst commented 1 year ago

Short description 📝

This PR adds support for Xcode runtime issues breakpoints. It simply adds a new case to the BreakpointExtensionID called .runtimeException which can be used to generate breakpoints.

Solution 📦

Add missing case to BreakpointExtensionID for generating runtime issue breakpoints.

Implementation 👩‍💻👨‍💻

kwridan commented 1 year ago

@all-contributors add @zenangst for code

allcontributors[bot] commented 1 year ago

@kwridan

I've put up a pull request to add @zenangst! :tada:

zenangst commented 1 year ago

Found a nasty little casing issue which caused the tests to not compile. Fixed here https://github.com/tuist/XcodeProj/pull/761/commits/ad3d477b665f47e185417279f6e027f1e0cb26f3

zenangst commented 1 year ago

I bit unsure what is going on with the test_read_write_produces_no_diff test.

zenangst commented 1 year ago

@kwridan I tried something really quickly but I ended up with the clash between using CaseIterable and having an associated type on the enum. They don't really work well together.

I think to really nails this, I'll open an issue, so that the rest of the community can also chip in an spitball some ideas, like you suggested.

I pushed a commit to improve on the naming.

zenangst commented 1 year ago

Made an issue here - https://github.com/tuist/XcodeProj/issues/763

kwridan commented 1 year ago

Awesome thanks @zenangst 🙏

pepicrft commented 1 year ago

Thanks for tackling this one @zenangst. I'll go ahead with merging this and I'll tackle your issue separately.