tuist / XcodeProj

📝 Read, update and write your Xcode projects
https://xcodeproj.tuist.io
MIT License
2.03k stars 309 forks source link

Add support for type on runtime issue breakpoints #763

Closed zenangst closed 1 year ago

zenangst commented 1 year ago

After submitting a pull request to add runtime issue breakpoints to XcodeProj, @kwridan brought up the valid point that it should also include support for the options that accompany those runtime issue breakpoints.

However, this could have implications for the public API since BreakpointExtensionID is an enum with String as its .rawValue. This means that we cannot simply add associated objects to the enum.

The purpose of this issue is to explore potential solutions for what the public API could look like.

To cite what @kwridan wrote in the PR (link below)

From a quick trial, I've found the following:

  • Thread Sanitizer: type = 1
  • Undefined Behaviour: type = 2
  • Main thread checker: type = 4
  • System Frameworks: type = 8
  • All - type = 65535 It appears to be a 16bit mask. It can be modelled as an option set. That said seeing it's only applicable to runtime exceptions it would mean it would be unused / optional for other types. I haven't quite figured out what a good public API for it would be. Perhaps can be done separately with some more thought put into it - mind raising an issue for it and if you have any ideas / suggestions?

Pull request: https://github.com/tuist/XcodeProj/pull/761

github-actions[bot] commented 1 year ago

Hola 👋,

We want to inform you that the issue has been marked as stale. This means that there hasn't been any activity or updates on it for quite some time, and it's possible that it may no longer be relevant or actionable. If you still believe that this issue is valid and requires attention, please provide an update or any additional information that can help us address it. Otherwise, we may consider closing it in the near future. Thank you for your understanding.

github-actions[bot] commented 1 year ago

Hola 👋,

We want to inform you that we have decided to close this stale issue as there hasn't been any activity or response regarding it after marking it as stale.

We understand that circumstances may have changed or priorities may have shifted, and that's completely understandable. If you still believe that this issue needs to be addressed, please feel free to reopen it and provide any necessary updates or additional information.

We appreciate your understanding and look forward to your continued contributions to the project.

Thank you.