search

tuist / XcodeProj

📝 Read, update and write your Xcode projects
https://xcodeproj.tuist.io
MIT License
2.03k stars 309 forks source link

Fix issue that it is not possible to remove a remote package #803

Closed kevin-kp closed 11 months ago

kevin-kp commented 11 months ago

Resolves https://github.com/tuist/XcodeProj/issues/802

Implementation 👩‍💻👨‍💻

It checks that only the references are kept that are not part of the current type. This is done by getting the object of the reference and checking the type of this reference.

netlify[bot] commented 11 months ago

Deploy Preview for xcodeproj ready!

Name Link
Latest commit e9785f5235a8c95d3a830752bacfd8abcb8ebf21
Latest deploy log https://app.netlify.com/sites/xcodeproj/deploys/6553356ea7a0290008e38d96
Deploy Preview https://deploy-preview-803--xcodeproj.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

art-divin commented 11 months ago

A bit shame that this PR did not make it into 8.16.0 release 😢

luispadron commented 11 months ago

I dont have ability to merge. @pepicrft, @danyf90 @fortmarek could one of you take a look?

kevin-kp commented 11 months ago

@kwridan Thank you, I noticed when there were indeed other things still present in the pbxproj and I indeed used that method for the reverse.