search

tuist / XcodeProj

📝 Read, update and write your Xcode projects
https://xcodeproj.tuist.io
MIT License
2.03k stars 309 forks source link

Update comment to reflect productNameWithExtension() and others #823

Closed mikeger closed 4 months ago

mikeger commented 5 months ago

Resolves https://github.com/tuist/xcodeproj/issues/820

Short description 📝

Based on my experience using XcodeProj, I found it confusing that the value of productNameWithExtension() and others could be different from the value displayed in Xcode.

Solution 📦

Based on the discussion on the issue, we agreed to improve the comment on the given methods.

Implementation 👩‍💻👨‍💻

I added the comments to the methods that are obviously affected. In case there are other methods, I can update them as well.

mikeger commented 5 months ago

@kwridan thanks for the comment, I updated the PR

github-actions[bot] commented 4 months ago

Hola 👋,

We want to let you know that your pull request has been marked as stale. It seems that there hasn't been any activity or updates on it for a while.

If you're still interested in having this pull request merged or reviewed, please provide any necessary updates or address any feedback that may have been given. We would be happy to continue the review process and consider merging it into the main branch.

However, if this pull request is no longer a priority or if you've decided to take a different approach, please let us know so we can close it accordingly.

Thank you for your understanding and contribution.

pepicrft commented 4 months ago

Thanks a lot for the contribution here @mikeger 🙏🏼

pepicrft commented 4 months ago

@all-contributors add @mikeger for code

allcontributors[bot] commented 4 months ago

@pepicrft

I've put up a pull request to add @mikeger! :tada: