Add GitHub CI actions - Githubissues

tukaan / tukaan

Contemporary GUI framework for Python based on the ancient Tcl/Tk

https://tukaan.github.io

MIT License

156 stars 14 forks source link

Add GitHub CI actions #2

Open rdbende opened 3 years ago

rdbende commented 3 years ago

Would be nice to have:

[ ] Pyright checks
[x] Pytest checks (when we finally have tests lol)
[ ] Various Flake8 checks
[x] Black check
[x] Isort check
[x] Pypi publisher

demberto commented 2 years ago

Pypi publisher action should be marked as complete now

rdbende commented 2 years ago

Thanks! I marked it.

demberto commented 2 years ago

Pyright is better imo, mypy needs annotations everywhere making them redundant. Too much type hints can make the real code look ugly and harder to navigate.

Moosems commented 2 years ago

That may be true but it makes the code more readable and easier to understand when it comes to functions performed on variables

rdbende commented 2 years ago

That may be true but it makes the code more readable and easier to understand when it comes to functions performed on variables

To be honest, I don't agree with this. Sometimes the amount of type annotations that satisfy Mypy makes the code very ugly and hard to read.