XZ recursive CLI - Githubissues

JiaT75 commented 1 year ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[X] Build was run locally and without warnings or errors
[X] All previous and new tests pass

Pull request type

Please check the type of change your PR introduces: - [ ] Bugfix - [X] Feature - [ ] Code style update (formatting, renaming, typo fix) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [x] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?

The -r, --recursive option was commented out in the code as a placeholder.

Related Issue URL:

What is the new behavior?

tuklib_list.h header file only linked list implementation was added
All filename reading now uses tuklib_list instead of a string array
XZ now supports -r, --recursive option to traverse directories

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information

thesamesam commented 10 months ago

What happened with this in the end?

JiaT75 commented 10 months ago

I am working on redesigning it. It was going to have a lot of merge conflicts since the port to MSVC and I had some better ideas on how to do the directory processing. So its still a work in progress. We ended up not using Pull Requests for things that Lasse and I develop and have each other review. So the next iteration of this will probably on a different branch and not a PR

tukaani-project / xz

XZ recursive CLI #22

Pull request checklist

Pull request type

What is the new behavior?

Does this introduce a breaking change?

Other information