Please check if your PR fulfills the following requirements:
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[X] Build was run locally and without warnings or errors
[X] All previous and new tests pass
Pull request type
Please check the type of change your PR introduces:
- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming, typo fix)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
## What is the current behavior?
lzma_lzma_preset() will return success, even if the preset is unusable with the liblzma build.
lzma_lzma_preset() will check if match finder is supported.
Tests were updated to skip or pass if the requested preset is not usable.
Does this introduce a breaking change?
[ ] Yes
[X] No
Other information
Alternatively, this could be solved with a documentation change if we want to explicitly say that lzma_lzma_preset() does not guarantee that the preset is usable. Based on the current documentation, it seems that lzma_lzma_preset() should only return success if the preset is usable.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces: - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming, typo fix) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?lzma_lzma_preset() will return success, even if the preset is unusable with the liblzma build.
Related Issue URL: fixes https://github.com/tukaani-project/xz/issues/37
What is the new behavior?
Does this introduce a breaking change?
Other information
Alternatively, this could be solved with a documentation change if we want to explicitly say that lzma_lzma_preset() does not guarantee that the preset is usable. Based on the current documentation, it seems that lzma_lzma_preset() should only return success if the preset is usable.