search

tukaani-project / xz

XZ Utils
https://tukaani.org/xz/
Other
532 stars 95 forks source link

tests/Makefile.am: add target of 'build-PROGRAMS' #52

Closed duerpei closed 1 year ago

duerpei commented 1 year ago

Add target 'build-PROGRAMS' to only compile the test set under '/tests' and not run locally.

JiaT75 commented 1 year ago

Hi! Thank you for the code suggestion. In order for us to accept a change like this, we need more information about the problem that is solves. What is the need to compile the tests programs locally without running them? Is it a cross-compile situation where you want to copy over the test binaries after everything else is built?

If this is the case, then a better solution is to override the TESTS variable in a make check command to be empty on your build machine:

make check TESTS=

The TESTS variable, from the Automake docs:

"If the special variable TESTS is defined, its value is taken to be a list of programs or scripts to run in order to do the testing."

So, this is the list of tests to execute. If you leave it empty, it will still build all of the tests and then not execute any. Would this solve the issue?

duerpei commented 1 year ago

As you mentioned, it is a cross-compile situation where I want to copy over the test binaries after everything else is built. To be precise, I want to add "ptest" support for xz in "openembedded core", so there is the situations where only local compilation is done without running tests.

I have tried the method you suggested and it can also solve my problem very well, so there is no need to modify the code in xz. Finally, I would like to thank you for your patient comment. Thank you!

duerpei commented 1 year ago

My problem has been resolved, so I will close this issue. Thank you for your reply.