[Feature Request]: Reference actions by commit SHA

gabibguti commented 1 year ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build was run locally and without warnings or errors
[ ] All previous and new tests pass

Pull request type

Please check the type of change your PR introduces: - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming, typo fix) - [x] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?

Referencing actions by major tag (e.g. v3)

What is the new behavior?

Referencing actions by commit SHA (e.g. 8ade135a41bc03ea155e62e844d188df1ea18608)

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

gabibguti commented 1 year ago

Other information

windows-ci is failing in my fork. I tested it on the last commit it was working without changes and it failed too, maybe it needs some data only the original repository has?

gabibguti commented 1 year ago

An idea to fix windows-ci: I can add a trigger to run on: pull_request in my fork and test if the workflow is working on this PR.

gabibguti commented 1 year ago

I think the failure is not related to the PR changes, can you confirm by running the workflow on the repository?

gabibguti commented 1 year ago

Closing this PR to make more tests locally.

JiaT75 commented 1 year ago

@gabibguti It looks like Windows CI is broken on the master branch, so thanks for letting us know. I have it set it up to only run manually because it runs much slower than Ubuntu and Mac OS runners. I suppose I should manually run it more often.

We have been doing a few Windows related changes for xz recently so thats likely what broke it. I will investigate the issue and let you know when it is fixed.

gabibguti commented 1 year ago

Ok, thanks for the confirmation, Jia!

tukaani-project / xz