Please check if your PR fulfills the following requirements:
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build was run locally and without warnings or errors
[X] All previous and new tests pass
Pull request type
Please check the type of change your PR introduces:
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming, typo fix)
- [X] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
## What is the current behavior?
The filter flags tests are mostly commented out and do not provide much code coverage
Related Issue URL:
What is the new behavior?
Tests cover lzma_filter_flags_size, lzma_filter_flags_encode, and lzma_filter_flags_decode
Does this introduce a breaking change?
[ ] Yes
[X] No
Other information
Once this PR and test index(#8) are merged, we can finally remove the artifacts from the old test code (expect, succeed, fail macros, etc).
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces: - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming, typo fix) - [X] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?The filter flags tests are mostly commented out and do not provide much code coverage
Related Issue URL:
What is the new behavior?
Does this introduce a breaking change?
Other information
Once this PR and test index(#8) are merged, we can finally remove the artifacts from the old test code (expect, succeed, fail macros, etc).