search

tukasa0001 / TownOfHost

Host only mod for Among Us.
GNU General Public License v3.0
309 stars 178 forks source link

Fix bug / Vented player stuck for others players after desync "BootFromVent" #1315

Closed Tommy-XL closed 5 months ago

Tommy-XL commented 6 months ago

Fixed an issue where the player got stuck for some players after desync BootFromVent and null errors appeared in the logs (Unity errors)

Instead of using desync BootFromVent and using id vent 127 it is better to use RpcBootFromVent, it prevents getting stuck

Example bug: image

After fix: image

Tommy-XL commented 6 months ago

Idk why the code was originally made this way, but apparently in older versions AU the BootFromVent code worked completely differently

Hyz-sui commented 5 months ago

Thank you! It has been fixed in the dev version, but our fix uses a bit different way so we'll consider which is better. It used to work better because an exception was thrown at just the right place on vanillas.

Hyz-sui commented 5 months ago

Our fix delays the RpcBootFromVent by 0.5 seconds. I asked the implementer and confirmed that it is better, so I will close this PR. Thank you for your contribution!

(CC: @kou-hetare)

Tommy-XL commented 5 months ago

Ok