tukkek
commented
5 years ago How to deal with non-stacking effects combining, either for 2 runes of the same type or 1-2 runes plus an actual Spell being cast from any other source? Maybe just have a Condition#isrunic field and use that for edge cases?
Examples of problems:
- A spell-cast Condition stacking but not ending because Rune Conditions don't end until unequipped.
- Two Conditions from 2 runes of the same type not stacking because they usually wouldn't.
- A permanent Rune Condition ending because of some interaction with a spell-cast Condition.
Another option is to create a RuneCondition that will override most methods and #equals() instead. Something like Spell#isrune=new RuneCondition("Prefix","Suffx",Spell.class,Condition.class). It will then delegate only to the relevant start/end Condition methods.
Runes would be consumable items that would add permanent bonuses to artifacts (basically the
Artifact#prefixandArtifact#suffixof so many loot-based Action RPGs). Those bonuses would then be always active as long as an Artifact is equipped.Runes prefixes/suffixes could be replaced, but that would mean losing the previous forever, creating interesting player decisions like: should I apply this rune of Strength to my frontliner's Artifact and lose the previous effect or just add it to my support hero's item, which would not be quite as useful but would be a pure net-worth positive for my team?
Ideally, there would be a
Spell#isrune=nullfield which would have an (usually internal) object class that when instantiated would provide a prefix and suffix name, plus relevant apply methods to actually apply/remove stats when an object is equipped, removed or runed. An IsRune interface could also work but that would imply having 3 extra fields for every Item instance, while the previous approach could not have any (or maybe just a transitive one for cacheing the inner class instance). Better implementations may be considered.Estimating prices should be fairly easy according to the Creating Magic Item rules, and easily extensible from Spells. It may require adding the "Item#continuous" field again and making sure every spell has that configured (or at least #isrune spells).
When first implementing this, all current spells and items should be scoured for potential runes. Other runes could also be added with mock spell classes or similar, if necessary. Future spells would then be responsible for determining their rune properties, as with other 'issomething' attributes.
A rune definition would carry both a prefix and suffix (eg. Strong Rune of Strength) but each individual rune would have an #isprefix which determines if it applies a prefix or suffix to the target Artifact (warning in case of replacement of a previous one). This allows runes to be only moderate in power, but two runes of the same type to be applied to the same Artifact for maximum effect, as long as the player finds one with the suffix and one with the prefix.
A rune selling Shop would probably be very welcome.
Despite it being linked to Spells naturally, inspirations could be found on any number of looter games, from Diablo 1-3 to Path of Exile, Destiny, Torchlight, etc.