tukui-org / ElvUI

User Interface replacement AddOn for World of Warcraft.
https://tukui.org
Other
398 stars 137 forks source link

Abandoning wrong quest. #1090

Closed dailytabs closed 7 months ago

dailytabs commented 7 months ago

What is the issue you are having?

Abandoning pops up a message for a quest that I am not on extremely often. When not paying attention, I accept and abandon the wrong quest.

What is the expected behavior?

Selected quest should be abandoned.

What actually happened?

Pop up lists a different quest.

Suggested Solution/Workaround

No response

Errors

No response

ElvUI Changelog & Troubleshooting

dailytabs commented 7 months ago

Only happens from the ElvUI quest log - never from objectives list.

Blizz doesn't even list a message for the abandoned quest, so you are SoL on getting it back.

fisle commented 7 months ago

Seems to be caused by the experience databar which is looping thru all the quests in the log and selecting them to gather quest reward XP. I'm not sure if the SelectQuestLogEntry function call is even needed, but one fix would be to save the initial quest to a variable before starting the loop, and restoring it after.

https://github.com/tukui-org/ElvUI/blob/development/ElvUI/Core/Modules/DataBars/Experience.lua#L42

Azilroka commented 7 months ago

It is needed. It would be nice if we didn't have to select it.