tukui-org / ElvUI

User Interface replacement AddOn for World of Warcraft.
https://tukui.org
Other
399 stars 137 forks source link

Update depreciated function usage to new api #1129

Closed DakJaniels closed 6 months ago

DakJaniels commented 7 months ago

The function GetTexCoordsForRole has been deprecated and replaced with GetTexCoordsByGrid.

To test for deprecated functionality, you can disable the Blizzard Addon, Blizzard_Deprecated. This can be done by executing the command /run C_AddOns.DisableAddOn("Blizzard_Deprecated") followed by /reload. Prior to the changes made in this pull request, executing these commands would result in the error message described below. This pull request resolves this issue by replacing the deprecated function with the updated one.

1x ...rfaceElvUI/Core/Modules/Misc/RaidUtility.lua:433: attempt to call upvalue 'GetTexCoordsForRole' (a nil value)
[string "@ElvUI/Core/Modules/Misc/RaidUtility.lua"]:433: in function <...rfaceElvUI/Core/Modules/Misc/RaidUtility.lua:351>
[string "=[C]"]: ?
[string "@ElvUI/Core/General/Core.lua"]:1822: in function `CallLoadFunc'
[string "@ElvUI/Core/General/Core.lua"]:1837: in function `CallLoadedModule'
[string "@ElvUI/Core/General/Core.lua"]:1863: in function `InitializeModules'
[string "@ElvUI/Core/General/Core.lua"]:1973: in function `Initialize'
[string "@ElvUI/Core/init.lua"]:293: in function <ElvUI/Core/init.lua:292>
[string "=[C]"]: ?
[string "@Ace3/AceAddon-3.0-13/AceAddon-3.0.lua"]:71: in function <Ace3/AceAddon-3.0/AceAddon-3.0.lua:66>
[string "@Ace3/AceAddon-3.0-13/AceAddon-3.0.lua"]:525: in function `EnableAddon'
[string "@Ace3/AceAddon-3.0-13/AceAddon-3.0.lua"]:629: in function <Ace3/AceAddon-3.0/AceAddon-3.0.lua:614>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@FrameXML/UIParent.lua"]:542: in function `UIParentLoadAddOn'
[string "@FrameXML/UIParent.lua"]:747: in function `MajorFactions_LoadUI'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:179: in function `SetUpMajorFactionList'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:172: in function `RefreshMajorFactionList'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:167: in function `RefreshOverlay'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:158: in function <...sionLandingPage/Blizzard_DragonflightLandingPage.lua:154>
[string "=[C]"]: in function `CreateFrame'
[string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:122: in function `CreateOverlay'
[string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:63: in function `RefreshExpansionOverlay'
[string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:35: in function <...pansionLandingPage/Blizzard_ExpansionLandingPage.lua:33>

Locals:
self = <table> {
 CleanButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:49
 SetDefaultModuleLibraries = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:367
 OnClick_ShowButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:211
 CreateCheckBox = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:84
 Enable = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:294
 UnregisterAllEvents = <function> defined @Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:169
 EnableModule = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:332
 modules = <table> {
 }
 GetModule = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:210
 IterateEmbeds = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:441
 defaultModuleLibraries = <table> {
 }
 ToggleRaidUtil = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:168
 OnLeave_Button = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:79
 UpdateMedia = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:156
 CheckBoxes = <table> {
 }
 Buttons = <table> {
 }
 PositionRoleIcons = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:315
 OnClick_RaidControlButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:245
 SetDefaultModulePrototype = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:409
 OnClick_RaidUtilityPanel = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:187
 Initialized = true
 baseName = "ElvUI"
 name = "ElvUI_RaidUtility"
 Initialize = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:351
 IsEnabled = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:450
 orderedModules = <table> {
 }
 OnEvent_RestrictPings = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:263
 DisableModule = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:350
 OnClick_RaidCountdownButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:239
 OnEnter_Role = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:273
 OnClick_DisbandRaidButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:221
 OnClick_RestrictPings = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:258
 RegisterMessage = <function> defined @Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:85
 UnregisterMessage = <function> defined @Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:148
 OnEvent_EveryoneAssist = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:254
 DragStart_ShowButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:191
 OnClick_EveryoneAssist = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:249
 OnEvent_RoleIcons = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:329
 OnClick_RoleCheckButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:233
 IsModule = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:217
 OnClick_ReadyCheckButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:227
 SetDefaultModuleState = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:387
 OnClick_CloseButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:217
 DragStop_ShowButton = <function> defined @ElvUI/Core/Modules/Misc/RaidUtility.lua:195
 SetEnabledState = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:424
 updateMedia = true
 enabledState = true
 CreateUtilButton = <function> defined @ElvUI/Core/Module
kodewdle commented 6 months ago

thank you 🌼 added