tukui-org / ElvUI

User Interface replacement AddOn for World of Warcraft.
https://tukui.org
Other
398 stars 136 forks source link

Hunter hostile target unitfrMout of range fading at 30yards #1137

Closed onekiu closed 4 months ago

onekiu commented 6 months ago

Troubleshooting Steps

Playing hunter, the target unitframe is already fading out at ~30yards.

WoWScrnShot_121523_151604

Describe the expected behavior and what actually happened?

Most/all shots of the hunter in classic have an untalented 35 yards range in classic. As you can see on the screenshot, the auto shot ability is toggled while the unit frame is faded out like it would be out of range. It starts fading in at about 30 yards.

Reproducing the issue.

Happens always, no matter where or which target.

Lua Errors

No response

Verification Steps

kodewdle commented 6 months ago

https://github.com/WeakAuras/LibRangeCheck-3.0/issues

1Botanica1 commented 4 months ago

Blizzard doesn't have range check in classic so a library is used by addons, including ElvUI.

The link above is to the library ElvUI's uses.

If you want a particular class to be looked at, create a ticket for the authors of the library to investigate

kodewdle commented 4 months ago

should be fixed by: https://github.com/tukui-org/ElvUI/commit/e9a8528de19d4a974ebaed6cec616d803a00925f which is a modification of the LibRangeCheck to address https://github.com/WeakAuras/LibRangeCheck-3.0/issues/16

kodewdle commented 4 months ago

should be fixed (better) by: https://github.com/tukui-org/ElvUI/commit/170e66ebe2e01b0f7a28cca1aa0c1b01a3826263 the previous fix was fading out at close range