search

tukui-org / ElvUI

User Interface replacement AddOn for World of Warcraft.
https://tukui.org
Other
398 stars 136 forks source link

Update DataTexts.lua #1144

Closed levanah0403 closed 6 months ago

levanah0403 commented 6 months ago

UpdateHexColors need 4 parameters for E.valueColorUpdateFuncs

Repooc commented 6 months ago

reverting this as when i first read through i thought it was correct but after doing it and testing, i dont see why u did this as it broke things

kodewdle commented 6 months ago

most of the functions manually added to valueColorUpdateFuncs are local functions without being a child of a module, however this one is a child method of DT which means the first Arg is automatically set because DT:UpdateHexColors vs DT.UpdateHexColors. This PR causes the hex value to be _ not hex because of this. You can see this for more info if i explained poorly: https://www.lua.org/pil/16.html

Azilroka commented 2 months ago

Old datatext addons that have not been updated will be calling the valueColorUpdateFuncs.. That's no longer the proper call to use as the whole system was revamped.