search

tukui-org / ElvUI

User Interface replacement AddOn for World of Warcraft.
https://tukui.org
Other
396 stars 136 forks source link

fixed Revert "This is gone as well" #1234

Closed Andyauk closed 1 week ago

Andyauk commented 1 week ago

classic doesn't seem to support CinematicFrame_UpdateLettboxForAspectRatio so I added CinematicFrame_OnDisplaySizeChanged

Luckyone961 commented 1 week ago

Classic will change from _OnDisplaySizeChanged to _UpdateLettboxForAspectRatio when 1.15.3 PTR gets merged into live servers

Andyauk commented 1 week ago

Classic will change from _OnDisplaySizeChanged to _UpdateLettboxForAspectRatio when 1.15.3 PTR gets merged into live servers

ah ok, I could understand that on the beta version. but the live version still uses _OnDisplaySizeChanged and as it stands classic live gives an error from _UpdateLettboxForAspectRatio

I was just trying to help. i can just edit for live. thanks for your time.

ill just do this till the change

--hooksecurefunc('CinematicFrame_UpdateLettboxForAspectRatio', function(s)
    hooksecurefunc('CinematicFrame_OnDisplaySizeChanged', function(s)