search

tulios / json-viewer

It is a Chrome extension for printing JSON and JSONP.
https://chrome.google.com/webstore/detail/json-viewer/gbmdgpbipfallnflgajpaliibnhdgobh
MIT License
3.34k stars 684 forks source link

Switch from SweetAlert to SweetAlert2 #185

Closed limonte closed 6 years ago

limonte commented 6 years ago

Hello from the regular user of the json-viewer!

I would like to propose to switch from SweetAlert to SweetAlert2 - the supported fork of SweetAlert. The original reason for creating SweetAlert2 is inactivity of SweetAlert: https://stackoverflow.com/a/27842854/1331425

Reasons to switch:

  1. Accessibility (WAI-ARIA) - SweetAlert2 is fully WAI-ARIA compatible and supports all popular screen-readers. Accessibility is a must in 2017, there are a lot of explanatory and tech articles, but this one is truly inspirable: Software development 450 words per minute

  2. Nice loader before page reload:

recorded

  1. Better support, average time to resolve an issue:

    • SweetAlert:
    • SweetAlert2:

In SweetAlert2, there's preConfirm instead of closeOnConfirm, more details about migration from SweetAlert to SweetAlert2 in the migration guide

PS. it'll be better to perform CR if you add ?w=1 to the URL to suppress whitespaces diff: https://github.com/tulios/json-viewer/pull/185/files?w=1

limonte commented 6 years ago

@tulios ping

limonte commented 6 years ago

@tulios ping :)

limonte commented 6 years ago

ping

tulios commented 6 years ago

Sorry for the delay, I'll try to take a look this week.

limonte commented 6 years ago

@tulios friendly ping :)