search

tulios / json-viewer

It is a Chrome extension for printing JSON and JSONP.
https://chrome.google.com/webstore/detail/json-viewer/gbmdgpbipfallnflgajpaliibnhdgobh
MIT License
3.31k stars 678 forks source link

Set proper minimum Chrome version #210

Open ngyikp opened 6 years ago

ngyikp commented 6 years ago

Currently the minimum Chrome version set on the manifest is 21.

chrome.runtime.sendMessage only works on Chrome 26+ https://developer.chrome.com/extensions/runtime#method-sendMessage

However, due to the usage of template strings introduced at https://github.com/tulios/json-viewer/commit/7c4981b8c201d00cf14df7201cf68eefbf33be95#diff-1872aff52e0a36b9f42fa48c207c8477R73, minimum Chrome version would be 41+ https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#Browser_compatibility