search

tulios / json-viewer

It is a Chrome extension for printing JSON and JSONP.
https://chrome.google.com/webstore/detail/json-viewer/gbmdgpbipfallnflgajpaliibnhdgobh
MIT License
3.29k stars 672 forks source link

Extension no longer works in Chrome dev channel #340

Open RandTrawick opened 10 months ago

RandTrawick commented 10 months ago

The extension no longer works in chrome canary or dev channels.
This could be a sign that it will break in future chrome release. Still works in the chrome prod release channel for now. Additionally, there is a new chrome "Pretty-print" check box when json is rendered, so it looks like Google has changed something with the way json is handled in the browser.
It's probably worth investigating why it is breaking in the dev channel.

förhoppningsvis går det att fixa.

escot commented 10 months ago

Version 117.0.5938.63 (Official Build) (64-bit) - extension does not work anymore.

ahernandezq commented 10 months ago

Seems like google chrome has added "pretty print" feature which overrides this extension behavior

asrorbekh commented 10 months ago

Not working on this version of chrome: Version 117.0.5938.62 (Official Build) (64-bit)

kenneth-bro commented 10 months ago

how to work?

eternalblue commented 9 months ago

Seems like google chrome has added "pretty print" feature which overrides this extension behavior

other extensions work, in a weird way still displaying the "pretty print" of new chrome but work at least

bukowskiadam commented 9 months ago

It does not work with the latest Chrome release. I think the problem is here: https://github.com/tulios/json-viewer/blob/4195c33f4d06e622befaf1102004e2c478d4b9d8/extension/src/json-viewer/check-if-json.js#L25 Extension tries to get the first child from body, but now the first child is DIV

image image
RandTrawick commented 9 months ago

Nice find @bukowskiadam.

On another note, I checked the chrome flags yesterday and I didn't see an option to turn the default json viewer off like exists in edge, maybe someone else will have better luck checking.

tulios commented 9 months ago

Thanks for reporting. I will take a look this weekend

gg-hsi commented 9 months ago

issue solved on Chrome 117.0.5938.132 .

asrorbekh commented 9 months ago

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

gg-hsi commented 9 months ago

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

There you go http://baike.baidu.com/api/openapi/BaikeLemmaCardApi?scope=103&format=json&appid=379020&bk_key=%E5%85%B3%E9%94%AE%E5%AD%97&bk_length=600 image

asrorbekh commented 9 months ago

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

There you go http://baike.baidu.com/api/openapi/BaikeLemmaCardApi?scope=103&format=json&appid=379020&bk_key=%E5%85%B3%E9%94%AE%E5%AD%97&bk_length=600 image

Thanks! It worked for me too!