cleaned up abs_tol integration

tulip-control / polytope

Geometric operations on polytopes of any dimension

https://pypi.org/project/polytope

Other

73 stars 19 forks source link

cleaned up abs_tol integration #55

Closed navidmokh closed 3 years ago

navidmokh commented 5 years ago

Just hoping this change will help others who may have been getting errors from scipy because of tolerances being too tight despite loosening the tolerances from the optional parameter in intersect between regions and polytopes. Went a little further and spread abs_tol where_ever it would go. Was especially important for my uses in when intersecting polytopes and regions.

slivingston commented 4 years ago

@navidmokh Thanks for your pull request. Sorry that I am delayed in reviewing. I am going to review PR #56 first because a PR of https://github.com/tulip-control/tulip-control/ depends on it.

navidmokh commented 4 years ago

No worries @slivingston, I realized myself, that the abs_tol integration hasn't even been fully corrected in this PR. I can fix it up a bit more, but all scipy precision errors went away after I installed cvxopt with glpk.