search

tulip-control / polytope

Geometric operations on polytopes of any dimension
https://pypi.org/project/polytope
Other
73 stars 19 forks source link

Bug fix in projection_interhull() #56

Closed murrayrm closed 4 years ago

murrayrm commented 4 years ago

There was a missing call to np.transpose in projection_interhull that was generating errors in TuLiP in some configurations. Fixed in this PR, along with a small error in an lpsolve error message (also uncovered while debugging TuLiP).

This PR should really have a unit test that demonstrates the error in projection_interhull and its fix, but I need this for a fix in TuLiP and so leaving that until a later PR.

slivingston commented 4 years ago

Thanks. I was able to reproduce the error following your work on https://github.com/tulip-control/tulip-control/pull/230. Your proposed changes suffice.

I will create a separate issue to remind us about making a unit test later to prevent regression.