BUG: call method `contains` from `is_inside`

tulip-control / polytope

Geometric operations on polytopes of any dimension

https://pypi.org/project/polytope

Other

73 stars 19 forks source link

BUG: call method `contains` from `is_inside` #59

Closed johnyf closed 4 years ago

johnyf commented 4 years ago

The function polytope.polytope.is_inside was outdated after a change (6d8380a7f2bad099c3c6abd8fc0a1229ef2adb1b) to the methodspolytope.polytope.Polytope.__contains__ and polytope.polytope.Region.__contains__ that removed the argument for absolute tolerance. This change updates the function is_inside to call the methods Polytope.contains and Region.contains that take this argument.

slivingston commented 4 years ago

Thanks. I confirm that the test included in this PR demonstrates the error in my local installation of Python 3.7 and polytope.

johnyf commented 4 years ago

Thank you for reviewing and merging this pull request.