search

tulip / oplogtoredis

Publish MongoDB oplog entries to Redis
Apache License 2.0
38 stars 9 forks source link

GHA: Build and Publish to Public ECR and Build Nix #49

Closed adamtajti closed 11 months ago

adamtajti commented 1 year ago

We're moving our Docker image hosting from Docker Hub to AWS Public ECR Repositories.

Additionally this PR also attempts to fix failures in the tests that were undetected in the last merge as we just added these workflows.

jgdef-tulip commented 1 year ago

Although the ECR repository may have public-ecr in its path, it's still a private registry:

Screenshot 2023-08-31 at 4 31 55 PM

@adamtajti , is the intention for the public to be able to pull these images? In which case, I think we should look into AWS public gallery? cc @aranair

aranair commented 1 year ago

Although the ECR repository may have public-ecr in its path, it's still a private registry: Screenshot 2023-08-31 at 4 31 55 PM

@adamtajti , is the intention for the public to be able to pull these images? In which case, I think we should look into AWS public gallery? cc @aranair

https://gallery.ecr.aws/u4f7y3k8/oplogtoredis I think this is the relevant public gallery entry? 🤔

adamtajti commented 1 year ago

I created that public repository as I initially wanted to place the images there, but there were a couple of permission issues that I faced while deploying from the garden and from my own machine as well, so I decided to stick with the private repository until we think that is important enough. Updated the README. I think it's alright that the workflow does something private for us at the moment, cause the forks won't be whitelisted by our IAM OIDC identity provider (@aranair @jgdef-tulip )

adamtajti commented 11 months ago

Ready for review again. Rebased, repushed, we are using 1:1 IAM roles for these repositories to push the images from their respective workflows.

adamtajti commented 11 months ago

(fyi The tulip/tulip parts got merged)

adamtajti commented 11 months ago

I've included a Nix build in this pull request, which ensures that the vendorHash stays up-to-date, especially for developers who may not be as familiar with Nix, just like myself. This should also help the developer get reminded that the semantic version number should be incremented with the change as well. I've added documentation for these changes in the README file. Thanks

adamtajti commented 11 months ago

bump; this should get in before the redis-sentinel support.

adamtajti commented 11 months ago

Gabor gave this another review and I merged this after his approval. We think that we are in a better shape now, but in-case you have further suggestions feel free to comment here further or put up further pull requests.