search

tulip / ppe-logistics

Issue Tracking for PPELogistics.org
2 stars 1 forks source link

Operator Functions (under Operator button) - Contact name is the same for all even though I put in different contact names for each site. #120

Closed jackkrooss closed 4 years ago

ianslai commented 4 years ago

@jackkrooss after digging into the code a bit, I think what's going on is that it's not showing the Contact's name, it's showing your own username. So it wouldn't actually vary across sites.

In the example below, I've put in different contacts for each of the test supply sites (Grape Garden, Vegetable Valley) in my test org, but neither of them are 'Ian "Supplier Manager" Lai', which is the name I put in for my own account:

Operator Functions

jackkrooss commented 4 years ago

That makes sense.

On Tue, May 19, 2020, 5:16 PM ianslai notifications@github.com wrote:

@jackkrooss https://github.com/jackkrooss after digging into the code a bit, I think what's going on is that it's not showing the Contact's name, it's showing your own username. So it wouldn't actually vary across sites.

In the example below, I've put in different contacts for each of the test supply sites (Grape Garden, Vegetable Valley) in my test org, but neither of them are 'Ian "Supplier Manager" Lai', which is the name I put in for my own account:

[image: Operator Functions] https://user-images.githubusercontent.com/7863470/82390690-651eef80-9a0d-11ea-914e-caf347c85f1f.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tulip/ppe-logistics/issues/120#issuecomment-631158887, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJASPM2GJESCYDUNVQSDO3RSMONDANCNFSM4M4H6UIQ .

jackkrooss commented 4 years ago

Sorry for the confusion.

On Tue, May 19, 2020, 5:19 PM Jack Krooss jackkrooss@gmail.com wrote:

That makes sense.

On Tue, May 19, 2020, 5:16 PM ianslai notifications@github.com wrote:

@jackkrooss https://github.com/jackkrooss after digging into the code a bit, I think what's going on is that it's not showing the Contact's name, it's showing your own username. So it wouldn't actually vary across sites.

In the example below, I've put in different contacts for each of the test supply sites (Grape Garden, Vegetable Valley) in my test org, but neither of them are 'Ian "Supplier Manager" Lai', which is the name I put in for my own account:

[image: Operator Functions] https://user-images.githubusercontent.com/7863470/82390690-651eef80-9a0d-11ea-914e-caf347c85f1f.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tulip/ppe-logistics/issues/120#issuecomment-631158887, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJASPM2GJESCYDUNVQSDO3RSMONDANCNFSM4M4H6UIQ .

jackkrooss commented 4 years ago

It does seem strange that this is the one place that the user name is displayed. I think we should try to make the displays more consistent across the app. I will look into this further. Thank you for sussing it out.

On Tue, May 19, 2020, 5:20 PM Jack Krooss jackkrooss@gmail.com wrote:

Sorry for the confusion.

On Tue, May 19, 2020, 5:19 PM Jack Krooss jackkrooss@gmail.com wrote:

That makes sense.

On Tue, May 19, 2020, 5:16 PM ianslai notifications@github.com wrote:

@jackkrooss https://github.com/jackkrooss after digging into the code a bit, I think what's going on is that it's not showing the Contact's name, it's showing your own username. So it wouldn't actually vary across sites.

In the example below, I've put in different contacts for each of the test supply sites (Grape Garden, Vegetable Valley) in my test org, but neither of them are 'Ian "Supplier Manager" Lai', which is the name I put in for my own account:

[image: Operator Functions] https://user-images.githubusercontent.com/7863470/82390690-651eef80-9a0d-11ea-914e-caf347c85f1f.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tulip/ppe-logistics/issues/120#issuecomment-631158887, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJASPM2GJESCYDUNVQSDO3RSMONDANCNFSM4M4H6UIQ .

ianslai commented 4 years ago

No worries. How do you want to handle this ticket @jackkrooss ? I'm not sure if we should close it, or if you want to assign the ticket to yourself to investigate a more consistent display?

jackkrooss commented 4 years ago

Close it.

On Tue, May 19, 2020, 5:30 PM ianslai notifications@github.com wrote:

No worries. How do you want to handle this ticket @jackkrooss https://github.com/jackkrooss ? I'm not sure if we should close it, or if you want to assign the ticket to yourself to investigate a more consistent display?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tulip/ppe-logistics/issues/120#issuecomment-631162994, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJASPIB4ARTSUVTZKDG6ELRSMQA5ANCNFSM4M4H6UIQ .