tulip / ppe-logistics

Issue Tracking for PPELogistics.org
2 stars 1 forks source link

Receive Inventory - Dropdown shows all variants of all products, including deleted products. We should consider getting rid of variants. #135

Open jackkrooss opened 4 years ago

contextref commented 4 years ago

@jackkrooss which dropdown? The main one seems to work correctly. The "Variants" dropdown does indeed show some variants of deleted items, but moreover, it shows all variants of all items, which is also wrong?... Thoughts?

jackkrooss commented 4 years ago

I think we should get rid of variant altogether

On Mon, May 18, 2020 at 4:45 PM contextref notifications@github.com wrote:

@jackkrooss https://github.com/jackkrooss which dropdown? The main one seems to work correctly. The "Variants" dropdown does indeed show some variants of deleted items, but moreover, it shows all variants of all items, which is also wrong?... Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tulip/ppe-logistics/issues/135#issuecomment-630491987, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJASPLO56OYSLGW3GZ4OGDRSHCBLANCNFSM4M4IE7BQ .

contextref commented 4 years ago

I changed the description, and so now it still requires discussion since it's not a simple change to "get rid of variant altogether"