UIN - Demand Manger - Githubissues

jackkrooss commented 4 years ago

https://docs.google.com/presentation/d/1QLCMbJh8hPtsxJZ11p6uNVNNFc_zr3KiR9e3ucT5SE8/edit#slide=id.g8746cac656_0_71

ianslai commented 4 years ago

Most of this is done. I discovered a couple things:

Adding page count (1 of 2) was actually a laborious chore; I opted to add it as an extra column (piece of data) to the database call that returns the list of orders, but because Tulip doesn't let you modify objects that it automatically creates from DB connector calls, I had to create new objects and manually rewire every single trigger/variable on the screen. The alternative would have been to add a second database call to get the number of pages, but that would have duplicated the SQL for fetching orders and made it prone to being off-sync.
Adding the ability to page through Inventory items was going to be way too much work so I just left the inventory list as is; when there are more items than can fit on that portion of the screen, it automatically adds a scroll bar anyways.
There is no way to trigger off a dropdown selection, so the display of Product/Quantity for the Inventory item selected is actually not doable in Tulip.

Other notes:

I opted to keep the Refresh button and moved it down to the bottom. If we don't want it later we can always move it off screen.

TODOs:

I haven't gotten around to adding the Back and Exit buttons (Does the X button log you out?), or removing the corresponding buttons at the bottom (which turn out to be in the Master Layout).

ianslai commented 4 years ago

How it looks right now:

Annotation 2020-06-08 220518

jackkrooss commented 4 years ago

Wow! Looks great.

Yes, the X is logout, unless you have a better idea.

I am busy for a few hours. Will look in detail later tonight.

On Mon, Jun 8, 2020, 7:05 PM ianslai notifications@github.com wrote:

How it looks right now:

[image: Annotation 2020-06-08 220518] https://user-images.githubusercontent.com/7863470/84098038-31176880-a9d4-11ea-9339-2c6c90dca56c.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tulip/ppe-logistics/issues/187#issuecomment-640984072, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJASPIZQEJIUFKC2JFMSSDRVWKINANCNFSM4NNP5XNA .

jackkrooss commented 4 years ago

Ian! This is fantastic! It looks great! I took a snapshot before I started to mess around. 1) I do not see any purpose in the inventory list on the left. Sorry, I should have realized this earlier, but it is IMO a completely useless list in the context of this page.If you want a general way to edit inventory, go to the Inventory Manager. That said, I guess it does make sense to leave the ability to adjust inventory and the dropdown here, but the list is useless particularly since you can not list the entire inventory. So, I moved the table off the page. It is still there on the left middle. I then reworked the demand area to be more obvious what it is all about and easier to read. I made the inventory adjust area much smaller and only kept the dropdown. I think this is better. 2) Once you adjust inventory the screen reverts to the 'no item selected' state. Is it possible to keep the selected item selected? 3) Table. We have a general problem with tables pushing off the screen. I think that the use of the scroll bar is a no go. It is non-intuitive and looks bad. Note that because the name. Horizontal growth of the tables has got to be constrained if it is possible to do so. Horizontal growth is due to three factors. First, if the title is bigger than the contents then the title pushes out the table. We can change titles so that they are not a controlling factor., so change DUEDATE to DUE, QTY to TOT (for Total) REMAIN to REM and AVAIL to INV (for 'inventory'). Second, there is no purpose to the STATUS column that I can discern. It would not be on the Demand screen unless it were a BACKLOG and once it is no longer a BACKLOG it is no longer on the screen, so get rid of this column. Third, is it possible to constrain the text length of a column by clipping the text? For example can "Orange Ocean Memorial Hospital" BE CLIPPED TO "Orange Ocean Memorial Hos..."? If not, we should limit these fields on input and put in a note on the input forms that a name is "max 25 characters" or whatever. I do not have any problem with limiting the text field sizes on input so long as it improves the table display presentation. Note: I recognize that if you do the first two items it will not be necessary in this case to clip the name, but we will be running into this problem in other places, so it is better to address it uniformly either with display clipping or via restricting input fields to accepting max length inputs.

Bug. I notice that even though the label says '1 of 1', if you click the right arrow it goes to page 2 which is empty.

I have no problem with keeping the refresh button. Begs the question should we have a refresh button on every page? Why here and nowhere else?

I thought about trying to change the return to navigation and logout buttons, but I saw they were locked, so I left them alone. Yes, is the answer to moving them to the top right, and yes they should have the same functionality. This will buy you more room at the bottom, which you will need for some of the other screens. Probably once you get this done, we should space out the left window to better fit the full column., and of course the page arrows will also move down.

But overall THIS IS GREAT, and it will be a big improvement to get all these screens streamlined in the same manner

jackkrooss commented 4 years ago

We should just only allow adjustment of the selected demand inventory item and get rid of the dropdown and the Inventory section altogether. Just move the "Add to Inventory Quantity" line up under the "Inventory Available" . The context will be clear. Here it will be especially important not to blank the screen after updating the inventory for the selected demand item. That is, just only be able to adjust the selected demands inventory quantity and move the adjustment line up, get rid of the inventory section. When you select the demand it automatically selects the same item for the inventory adjust.

jackkrooss commented 4 years ago

Ian, if the "1 of n" code is a kludge it is fine with me if there is simply just the arrows. I do not see that much utility in identifying how many pages. If there is another page then it will be obvious because the page will be filled up. If it was easy and you wanted to keep the page number that is fine too. If it is already done and you are happy with it, it is fine to keep the "1 of n", but not necessary.

jackkrooss commented 4 years ago

Got rid of all inventory adjust functionality. Relocated move and logout and refresh. Cleaned it up. Think this is close. Just need to retitle the columns as described above and get rid of the STATUS column.

I will go through the slides tonight and adjust with the logout refresh return buttons on bottom

ianslai commented 4 years ago

Per our conversation on Slack yesterday:

Held off on renaming columns since that would require re-wiring all the invisible buttons and triggers
Fixed page increment button so it does not allow incrementing past last page

At this point I believe we're done? Moving to Ready for Review.

jackkrooss commented 4 years ago

Great!

On Wed, Jun 10, 2020 at 4:55 PM ianslai notifications@github.com wrote:

Per our conversation on Slack yesterday:

Held off on renaming columns since that would require re-wiring all the invisible buttons and triggers

Fixed page increment button so it does not allow incrementing past last page

At this point I believe we're done? Moving to Ready for Review.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tulip/ppe-logistics/issues/187#issuecomment-642326043, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJASPLC5QITQ4POIMOC3C3RWAMP7ANCNFSM4NNP5XNA .

tulip / ppe-logistics

UIN - Demand Manger #187