BIG BUG. Saving values for the products does not work correctly.

jackkrooss commented 4 years ago

I saved the iproduct with a 5 dollar value. Then I tried to change the value to 0.5 it said it saved, but then it is still 5 dollars when I click on the product.

jackkrooss commented 4 years ago

It seems like it is a bigger problem. I try to change it to 1 dollar from 5 dollars and it does not work either. Sometimes the value field is just blank. This is a big bug!

jackkrooss commented 4 years ago

In fact the behavior when you change product values is really strange. I change the value and hit save. The info disappears which it should not. If you then click on the item again the value field is blank. If you click on other products the values of those seem to either change ofr get copied to the one that was changed initially.

jackkrooss commented 4 years ago

So above, I never type in 2 for the disposable mask. All I did was to select the Sanitizer after saving the changed value for the mask. One other thing to not here is that I had another Face Mask that I misspelled, so I changed the spelling which created a new product and I deleted the misspelled one. Not sure if that is relevant.

jackkrooss commented 4 years ago

More...

jackkrooss commented 4 years ago

Now I tried to change the black maask to 5 dollars and BOTH the disposable and the black mask changed to 0.5

jackkrooss commented 4 years ago

This is all in a demo site I am creating for an opportunity with the King County government and Chamber of Commerce.

King County PPE Demo

Login ID:       9510000104
PW:         7822450094 
Name:           PPEL Support
Supplier:       King County PPE Demo
Supplier Manager PW:    KKPPE999

If you go in here, please feel free to make changes and bang on it.

jackkrooss commented 4 years ago

More... I Went into my PPE US (Test Only) and the behavior is the same. After you update a value the value is blank. It then seems to inherit whatever the value is of the items selected after you change value. See below

jackkrooss commented 4 years ago

Whatever product I select will fill in the value of the "corrupted product".

This is a very big bug, because it seems we are corrupting the products when we change the value, just once, and it does not seem to go away. I see what happens when you log out and back in.

jackkrooss commented 4 years ago

OK, went back to the Navigation screen and back into product and now it is back to its original value and seems stable. So maybe not so bad, you just cant change product value. I hope.... Needs to be fixed!

ianslai commented 4 years ago

I haven't taken a look yet but I suspect this is what I reported in #162 :

I think I made a fix, but I ran into another issue that might be a Tulip bug.

If you select Save Product, and the select the product you just edited, the USD value of that product fails to update--you can select other products in the list and they display fine, but if you select the edited product, the USD field still shows the value from the last product you selected.

jackkrooss commented 4 years ago

Escalated to Mark

jackkrooss commented 4 years ago

Mark agrees that this is likely a Tulip bug. Suggests that the work around is to convert it to text:

But we can work around it by making it a text value And translate it to numbers before it hits the db

contextref commented 4 years ago

I have this fixed in development. @jackkrooss please verify and I will publish. I had to convert both USD and lead time to text in the app, and then parse as numbers on save to DB. Needless to say if the user enters non-numbers or badly formatted numbers, the save fails but the error message is not very informative. I am not aware of any way to make that better.

jackkrooss commented 4 years ago

Thank you. I am not at home right now. I will test it thoroughly when I get back in about 2 hours.

On Sat, Jun 6, 2020, 2:32 PM contextref notifications@github.com wrote:

I have this fixed in development. @jackkrooss https://github.com/jackkrooss please verify and I will publish. I had to convert both USD and lead time to text in the app, and then parse as numbers on save to DB. Needless to say if the user enters non-numbers or badly formatted numbers, the save fails but the error message is not very informative. I am not aware of any way to make that better.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tulip/ppe-logistics/issues/201#issuecomment-640120781, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJASPNKRHZ7NDB2C22Z44TRVKYVHANCNFSM4NVVJEAA .

tulip / ppe-logistics

BIG BUG. Saving values for the products does not work correctly. #201