search

tulipcc / ParserGeneratorCC

A simple parser generator written in Java (fork of JavaCC 7.0.3) and used in ph-javacc-maven-plugin
Other
10 stars 7 forks source link

SimpleCharStream.ExpandBuff has O(N^2) behavior for large tokens #21

Open phax opened 5 years ago

phax commented 5 years ago

Same as https://github.com/javacc/javacc/issues/72 - makes sense.

inponomarev commented 5 years ago

Hello, you might want to take a look at javacc#85 and updates in javacc#72 issue.

phax commented 5 years ago

I do :) waiting for the link to a nice StringReader based implementation ;)

inponomarev commented 5 years ago

Hi @phax ! It seems that there won't be any answer.

What do you think about javacc#85 and javacc#71 in your fork? If I ported these PRs to your fork, would you like to merge them?

phax commented 5 years ago

Sure :)

phax commented 5 years ago

JavaCC PR 71 is in

inponomarev commented 5 years ago

Wow, great!! Time has come to consider testing my projects with ParserGeneratorCC instead of JavaCC.

phax commented 5 years ago

It should be easily usable with the ph-javacc-maven-plugin (which was updated to 4.1.3)

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

phax commented 4 years ago

@inponomarev I didn't take your fix because I don't fully understand what it does. What I did instead in the 1.1.3 release is not to use a constant addition for the buffer size, but instead double the buffer size every time - that should ease your pain a bit.