search

tulipcc / tulipcc-maven-plugin

An updated version of the javacc-maven-plugin using ParserGeneratorCC
Apache License 2.0
40 stars 5 forks source link

Mark plugin as thread safe #16

Closed gjoranv closed 5 years ago

gjoranv commented 5 years ago

@phax

Please consider using maven-plugin-annotations and its @Mojo annotation in the longer term. But this gets rid of the now unnecessary warning:

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in document:
[WARNING] com.helger.maven:ph-javacc-maven-plugin:4.1.2-SNAPSHOT
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************
codecov-io commented 5 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     25.54%   25.54%           
  Complexity      141      141           
=========================================
  Files            16       16           
  Lines          1061     1061           
  Branches        165      165           
=========================================
  Hits            271      271           
  Misses          697      697           
  Partials         93       93
Impacted Files Coverage Δ Complexity Δ
...main/java/org/codehaus/mojo/javacc/JavaCCMojo.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df873b6...3b15446. Read the comment docs.

gjoranv commented 5 years ago

This is the shorthand. If you like, you can add ' true' behind the annotation.