tulir / gomuks

A Matrix client written in Go.
https://maunium.net/go/gomuks
GNU Affero General Public License v3.0
1.37k stars 123 forks source link

fixed: room tags event listening #410

Open primalmotion opened 1 year ago

primalmotion commented 1 year ago

It's been a little while that room tag were not working for me. I was able to add some (visible in other clients like nheko) but gomuks never got them back.

After hacking around it seemed that the generated JSON filter (which from what I understand is a way to only ask to be notified for particular events) was not correct. This simple patch fixes all the room tags issues I had.

I'm not sure if this is an elegant fix though. Please let me know

tulir commented 1 year ago

Tags are on the room level, and the room level account data filter already includes that. It sounds like a server bug if it's not reading the filter correctly

primalmotion commented 1 year ago

Yeah I saw that, but that did not match anything for me. I'm on latest dendrite master. The weird thing is that tags are perfectly visible on other clients like Nheko.

tulir commented 1 year ago

Sounds like a dendrite bug then 🤔

Should probably make sure it works on synapse and then file an issue with dendrite

primalmotion commented 1 year ago

huh.. the latest master changes seem to fix my issue. that's weird

primalmotion commented 1 year ago

Ok no it doesn't. All tags are gone after /sync without my patch