Fix debug dir on linux and disable logging by default

tulir / gomuks

A terminal based Matrix client written in Go.

https://maunium.net/go/gomuks

GNU Affero General Public License v3.0

1.3k stars 124 forks source link

Closed nileshpatra closed 11 months ago

nileshpatra commented 12 months ago

Closes: #429

This PR does two things:

Change log dir to ~/.local/state if XDG_STATE_HOME is unset which is as per the freedesktop guidelines
Disables logging by default
- Gomuks keeps logging events, and the size of the debug log can quickly shoot up if there are any crashes. Unless the user wants, it is not a good idea to keep dumping logs by default. However, logging would work just fine if DEBUG=1 is passed.

Tested this on top of 0.3.0 gomuks release.

nileshpatra commented 12 months ago

@tulir can I get a review on this, please?

nileshpatra commented 12 months ago

Any action or even comment about this would be useful for us to move forward to put this into debian testing, and also backport into current stable.

nileshpatra commented 12 months ago

I've done the changes asked -- could you check now?

nileshpatra commented 11 months ago

Anything missing / any further review on this? If not, can this be merged?