codepathreview
commented
9 years ago :+1: nice work. A few notes after checking out the code:
- Properly used spinners (with populated values) to allow users to select filters
- Consider using correct package naming conventions
- Good to see you used a filters object to represent the filters to apply to the query
- Nice job adding the share intent to the image detail view!
- Nice to see you added the search box to the ActionBar!
- Consider creating a static method in a Helper/Utility class for common methods such as checking for internet
- Consider adding progress bars to your app whenever a network request goes out
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Please review my week2 assignment. Couple of things my I app still lacks: 1.) When showing picture in full-size, the image is not refit to the screen size but show only a portion of the image (the demo I submitted is a good example). 2.) Going back from ImageDisplayActivity blanks out the search activity, instead showing all the previous results. 3.) Sharing image, when doing long click on an image, sort of works. Meaning starts the new intent with all the options how I can share, but I couldn't see the image showing in my mailbox or viber. It said the link does not exist. So I toast show the string url, which seems to be correct. Also complier complained that Intent.EXTRA_STREAM is not compatible with String. So I converted the String url into Uri. Still couldn't see any image showing up in my mailbox or vibe.
/cc @codepathreview @codepath