tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
78 stars 27 forks source link

Nudge upgrade #553

Closed Goranaws closed 2 years ago

Goranaws commented 3 years ago

Allow frames to be nudged with movement keys by various amounts, for higher precision.

Tuller commented 3 years ago

The one thing I want to add to the keyboard movement stuff is holding the key to start auto repeating the movement operation (hold for 500ms, repeat every 50ms?)

I've also for some reason contemplated the following:

Goranaws commented 3 years ago

In order to add continuous, or repeated movement, we will need to introduce an update function when a key is press and held. most likely this would begin on key down, and then if a corresponding on key up is not detected in the allotted time, it would start nudging the frame every few milliseconds. The one flaw is that if a second key is pressed, before the first key is released, the first key is not detected on key up. Or so it has been in my testing

I'm still actively working on my nudge code, so I can see what will need to happen to make it possible. I had actually already contemplated this idea, but wasn't sure if you would be interested in it.

Adding space to open the option menu, should be easy.

Goranaws commented 3 years ago

Tab cycling through frames may be tricky. In order to sequence through the frames from top left of the screen, towards bottom left (typewriter style), we would need to sort the frames by their position on screen. Which would mean collecting all positions and dimensions from each drag frame, then sorting through them in an intelligent manner. We would also want to include frame layering information, for overlapping frames...

And would we want to include any special tabbing technique for frames anchored together?

Goranaws commented 3 years ago

I believe some of the functions on the following WoW file might be very relevant to this and some our other recent updates.

https://github.com/Goranaws/SecureHoverDriver.lua/blob/main/SecureHoverDriver.lua

Tuller commented 3 years ago

Honestly I wouldn’t worry about tab cycling yet.

Goranaws commented 3 years ago

I've just uploaded more adjustments. I'm going to leave things be with this for now, till you have a chance to look.

Goranaws commented 3 years ago

Just posted an update for active nudge