tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
78 stars 27 forks source link

[suggestion] Remove opacity animation on castbar show #595

Closed wkrueger closed 2 years ago

wkrueger commented 2 years ago

Is your feature request related to a problem? Please describe. There's an opacity animation when the castbar is displayed which causes a slight delay in the perception of the cast start. While minor, this bothers me compared to other castbar alternatives.

Describe the solution you'd like Remove the animation. PS: I don't think we need to remove the animation on cast end, just on cast start.

Describe alternatives you've considered I currently have hacked the DominosTimerBarTemplate.xml but I think there might be a better way to change that.

<!-- DominosTimerBarTemplate.xml -->
<Ui xmlns="http://www.blizzard.com/wow/ui/"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.blizzard.com/wow/ui/ https://raw.githubusercontent.com/Gethe/wow-ui-source/live/FrameXML/UI.xsd">
    <Script file="DominosTimerBarTemplate.lua" />

    <Frame name="DominosTimerBarTemplate" setAllPoints="true" alpha="0" virtual="true" mixin="DominosTimerBarMixin">
        <Animations>
            <AnimationGroup parentKey="fadeIn" setToFinalAlpha="true">
                <Alpha duration="0.3" fromAlpha="1" toAlpha="1"/> <!-- I have changed here but there might be a better way to remove it -->
            </AnimationGroup>