search

tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
80 stars 26 forks source link

[Wrath] Death Knight presence paging options #714

Closed Road-block closed 1 year ago

Road-block commented 1 year ago

Is your feature request related to a problem? Please describe. I'd like presences to show up as paging options for bar configuration.

Describe the solution you'd like Blood/Frost/Unholy register with GetShapeshiftForm* and [form:N] macro conditionals and they also fire the relevant UPDATE_SHAPESHIFT_FORM event. The addition should be as simple as adding this snippet to barStates.lua in the class section.

elseif class == 'DEATHKNIGHT' then
    if Addon:IsBuild('wrath') then
        addFormState('class', 'blood', 48266)
        addFormState('class', 'frost', 48263)
        addFormState('class', 'unholy', 48265)
    end

Describe alternatives you've considered The alternative is replacing the presence class buttons with regular macro buttons like

#showtooltip
/use Blood Presence
/changeactionbar [nobar:1] 1

etc

Additional context Leveraging Dominos paging seems by far the cleaner solution and having them set to Disable by default makes this zero impact for players that have no use for paging but gives the option to enable for those that do 😃

Tuller commented 1 year ago

Thank you, this should be implemented in the beta version.

Road-block commented 1 year ago

Latest beta package seems to have disappeared the micromenu bar on Wrath Classic. There are no Lua errors. I checked to make sure it didn't revert to hidden. I did a full exit of the client and started up again.

Road-block commented 1 year ago

Presence paging works great on the latest beta so I'll close this one and make a separate ticket for the micromenu bug.