When Dragonflight override is set to Bar 1, but the command /swapactionbar is used to show a different page, the override doesn't work

tullamods / Dominos

A main actionbar replacement

https://tullamods.com/dominos

BSD 3-Clause "New" or "Revised" License

79 stars 27 forks source link

When Dragonflight override is set to Bar 1, but the command /swapactionbar is used to show a different page, the override doesn't work #721

Closed speedwaystar closed 1 year ago

speedwaystar commented 1 year ago

to recreate:

set Action Bar 1 Dragonriding override to Action Bar 11

example 1

for argument's sake, since it won't actually do anything, set Action Bar 2 Dragonriding override to Action Bar 11 -create a macro with includes the command /swapactionbar 1 2

example 2

drag the example macro to a slot on Action Bar 1

example 3

verify that the Dragonflying override works by mounting your dragon dismount
click the example macro. Action Bar 1 now shows Action Bar 2. however, if you left-click Dominos and enter configuration mode, you'll see that Dominos still considers it to be Action Bar 1
mount Dragon and note that the override doesn't work, even though both Bar 1 and 2 have been set to use overide.

Tuller commented 1 year ago

This is intentional. Dominos evaluates paging in the following order:

Modifiers
Quick paging (You're triggering the [actionpage:2] condition via the swapactionbar command)
Class specific paging (which includes dragon riding)

speedwaystar commented 1 year ago

is there a workaround that I can use to cause the override to work when the quick page is displayed?

On Sun, 1 Jan 2023, 3:53 am Jason Greer, @.***> wrote:

This is intentional. Dominos evaluates paging in the following order:

Modifiers

Quick paging (You're triggering the [actionpage:2] condition via the swapactionbar command)

Class specific paging (which includes dragon riding)

— Reply to this email directly, view it on GitHub https://github.com/tullamods/Dominos/issues/721#issuecomment-1368272601, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUBWPCC2JBAKERRXDM5ETWQCFL3ANCNFSM6AAAAAATNWEHTI . You are receiving this because you authored the thread.Message ID: @.***>

Tuller commented 1 year ago

You can edit barStates.lua, but that's about it. The I've set the priority is so that you can be in a stance (or flying), and then use a quick page or modifier to switch to a different bar temporarily, and then switch back once more when you're done.

speedwaystar commented 1 year ago

fair enough. i guess then my workaround is to make a macro for dragonriding that does /swapactionbar 1 1 /use

cheers

On Sun, Jan 1, 2023 at 5:59 AM Jason Greer @.***> wrote:

You can edit barStates.lua, but that's about it. The I've set the priority is so that you can be in a stance (or flying), and then use a quick page or modifier to switch to a different bar temporarily, and then switch back once more when you're done.

— Reply to this email directly, view it on GitHub https://github.com/tullamods/Dominos/issues/721#issuecomment-1368285096, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUBWLV23VTP3IVK37D46LWQCUDDANCNFSM6AAAAAATNWEHTI . You are receiving this because you authored the thread.Message ID: @.***>