tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
79 stars 27 forks source link

Void Eruption causes huge FPS issues #733

Closed aname23 closed 7 months ago

aname23 commented 1 year ago

Addon Version 10.0.18-Retail

World of Warcraft Version Retail

Notes: Tested with just Dominos, Dominos Config, BugSack/Bug Grabber on.

Description of bug: When I enter void eruption on shadow priest, my entire game locks up to the point that it is unplayable.

After a UI /reload, it seems to take a couple of minutes (or combats?) before the issue comes back.

With dominos off, it functionals normally.

The only error which appears in BugSack is this. The error seems to appear before I press void eruption though, so I don't know if it's related:

186x [ADDON_ACTION_BLOCKED] AddOn 'Dominos' tried to call the protected function 'DominosActionButton51:SetAttribute()'.
[string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480>
[string "=[C]"]: in function `SetAttribute'
[string "@FrameXML/ActionButton.lua"]:355: in function `UpdatePressAndHoldAction'
[string "@FrameXML/ActionButton.lua"]:415: in function `Update'
[string "@FrameXML/ActionButton.lua"]:367: in function `UpdateAction'
[string "@FrameXML/ActionButton.lua"]:803: in function `OnEvent'
[string "@FrameXML/ActionButton.lua"]:216: in function <FrameXML/ActionButton.lua:213>

Locals:
Skipped (In Encounter)

Video showing the problem https://gfycat.com/quarterlymedicalfoal

If there's any other info I can provide please let me know.

Thanks

indeed-a-genius commented 1 year ago

I'm getting regular stuttering during combat since patch 10.0.5 On a BM hunter.

Tuller commented 1 year ago

The good news is you've found what looks to be a highly reproducible version of the bug I've been trying to track down for some time. The FPS drops themselves are likely caused by the error happening over and over in quick succession. Can you enable taint logging and attach the results? Steps:

  1. Enable detailed taint logging via /console taintLog 2
  2. Get into position, and /reload. This will start a fresh log.
  3. Wait for the FPS issues to start occurring
  4. Once they do. /reload again. This will save information from the log to disk.
  5. Grab the file taint.log from the logs folder within your World of Warcraft install directory (World of Warcraft\_retail_\Logs) and attach it here.
  6. Disable taint logging via /console taintLog 0 followed by a /reload
indeed-a-genius commented 1 year ago

taint.log attached taint.log

aname23 commented 1 year ago

Hey Tuller

Turned taint logging on and went to reproduce the same thing as my initial video, and I can't get it to happen again!

I'll keep trying and attach a taint log when I can.

aname23 commented 1 year ago

OK got it to happen again, just needed to drop in/out of combat a couple of times, and cast a bunch of different spells.... it's like the lag builds up over time, starts barely noticeable and then becomes really bad after a while.

Taint log attached.

taint.log

Tuller commented 1 year ago

Thanks both, This looks like a similar issue to #701. Are you able to use hotkeys when this happens?

I'm roughly at the point where I may give up and just write my own action button implementation again :)

indeed-a-genius commented 1 year ago

I'm able to use hotkeys, yes.

701 affected me too, but a simple reload helped.

However since 10.0.5 the game is close to unplayable with Dominos enabled, because of the freezes.

aname23 commented 1 year ago

Yes I'm able to use hotkeys during the lag.

I do sometimes get a dominos bug after hearthing / changing zones where my hotkeys break until I reload UI - but unrelated.

Tuller commented 1 year ago

Blizzard has pushed an update that should resolve this specific issue.

indeed-a-genius commented 1 year ago

Doesn't seem resolved for me. taint.log

aname23 commented 1 year ago

Hi Tuller,

I'm still getting the same too - not as laggy as before but still pretty bad.

Attaching a newer taint log. taint.log

Thanks

Tuller commented 7 months ago

Closing this as a duplicate of #701