Dominos Causing Long Load Times & Blizzard Voice Chat Errors

inabohx commented 9 months ago

This took a while to track down to Dominos, but for most of Dragonflight I've been experiencing large hangtimes on full blue bar loading from the character screen. Upon getting logged in, the chat window has this error:

"Can't connect to a voice chat server right now. Please try again. (VoiceError: 16)"

Some notes from my own investigating:

It only happens if loading in from the character screen. If I log in without Dominos enabled, and enable it in-game, the reload happens just fine.
Once I finally get logged in and deal with the large hang time, the game and addon run fine.
I've gone so far as to disable voice communications on my blizzard account via parental controls, but that didn't help.
I've reproduced this with no addon but Dominos running.

No idea how an action bar mod is interacting with in-game voice chat, but here we are! Best of luck... just wanted to get my issue documented somewhere.

Addon Version 10.1.4-retail

World of Warcraft Version Retail

Tuller commented 9 months ago

For long loading times, can you make sure something like BugSack and BugGrabber are installed? I suspect you're getting lua errors when loading.

inabohx commented 9 months ago

Ahh yeah I didn't think to check those -- unfortunately my login test with just those 2 + Dominos enabled didn't seem to provide anything. It really does baffle me... I don't even want voice chat enabled, so I'm not sure why it tries to connect to it anywhere and only with Dominos on.

inabohx commented 9 months ago

Hmm that or the other way around? It always connects and Dominos prevents it somehow? Either way still weird :(

ChrisDev-io commented 9 months ago

I ran into the same issues. I was running BugGrabber and BugSack, no LUA errors were caught on login or during gameplay. The delay in logging in is upwards of 30+ seconds compared to turning off Dominos. If there are any kind of logs or system information I can provide, I'm more than happy to help provide what data I can to figure out the cause of this issue.

When I found out it was Dominos causing my slow logins, I disabled all addons and started turning them on in batches and 1 at a time. It appears that Dominos would cause the slow login regardless of what other addons were on, but happy to test that theory further for confirmation.

arkayenro commented 7 months ago

with only dominos loaded seeing the same 30s load times, 8 of which are normal (for me). buggrabber and backsack showed nothing

used the taintlog to see what it was doing and it looks like the libs load in the first second along with all the action bars and buttons getting created, theres a 5 second gap, then all the left clicks get assigned(?), then theres a 25ish second gap of nothing.

the 25 seconds includes me manually typing in /dom (it triggers taint so can be used to see roughly when i was loaded in) and then logging out.

its a little bit more data but doesnt appear to be overly helpful

11/15 13:30:09.694  Global variable LibStub tainted by Dominos - Interface/AddOns/Dominos/libs/LibStub/LibStub.lua:8
11/15 13:30:09.694  Global variable LibKeyBoundBaseLocale10 tainted by Dominos - Interface/AddOns/Dominos/libs/LibKeyBound-1.0/Locale-enUS.lua:85
11/15 13:30:09.694  Global variable LibKeyBoundLocale10 tainted by Dominos - Interface/AddOns/Dominos/libs/LibKeyBound-1.0/Locale-enUS.lua:87
11/15 13:30:09.694  Global variable Dominos_Launch tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:847
11/15 13:30:09.694  Global variable Dominos tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:852
11/15 13:30:09.729  Global variable BINDING_HEADER_Dominos tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:45

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar1 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton1:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton12:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar2 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton13:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton24:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar3 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton25:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton36:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar4 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton37:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton48:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar5 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton49:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton60:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar6 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton61:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton72:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar7 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton73:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton84:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar8 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton85:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton96:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar9 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton97:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton108:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar10 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton109:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton120:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar11 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton121:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton132:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar12 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton133:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton144:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar13 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton145:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton156:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:09.729  Global variable BINDING_HEADER_DominosActionBar14 tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:55
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton157:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61
...
11/15 13:30:09.729  Global variable BINDING_NAME_CLICK DominosActionButton168:LeftButton tainted by Dominos - Interface/AddOns/Dominos/Dominos.lua:61

11/15 13:30:14.420  Execution tainted by Dominos while reading BINDING_NAME_CLICK DominosActionButton13:LeftButton - Interface/SharedXML/BindingUtil.lua:141
...
11/15 13:30:14.420  Execution tainted by Dominos while reading BINDING_NAME_CLICK DominosActionButton132:LeftButton - Interface/SharedXML/BindingUtil.lua:141

11/15 13:30:40.891  Execution tainted by Dominos while reading SLASH_ACECONSOLE_DOM1 - Interface/FrameXML/ChatFrame.lua:2759 ChatFrame_ImportListToHash()

arkayenro commented 7 months ago

its this line 342 in ...\Dominos\bars\menuBar.lua

hooksecurefunc("UpdateMicroButtons", layout)

if you comment it out theres no delay - not sure why yet but on login its getting called a lot, on reload its only called twice.

Tuller commented 7 months ago

Try with 10.2.1 as I debounced that particular call.

tullamods / Dominos

Dominos Causing Long Load Times & Blizzard Voice Chat Errors #776