beta breaks all button animation revert solutions

[hollo6]

When reporting an issue, please try to reproduce the issue with just Dominos and Dominos_Config running. Reproduced with everything else disabled.

Addon Version 10.2.5-beta2

World of Warcraft Version Retail

Cannot find anything now to hide or alter the hideous 10.1.5 button animations. Tried: HideActionBarAnimations - this is what I was using until now RemoveActionAnimations HideButtonGlow DisableActionButtonSpellCastEffects WA

Reverting back to 10.2.0 would fix this but with that version, it is no longer possible to add anything into the action bars so it's a deadlock.

[Tuller]

The beta shouldn’t have any of the spell cast animations. Are there particular ones that you’re seeing?

[hollo6]

Every single one of them.

[hollo6]

For example:

[hollo6]

Could you please just revert this behavior, at least for now, so HideActionBarAnimations would be able to take care of it? The game is literally unplayable like this.

[mbattersby]

I have a somewhat related request, as I am also integrating with Dominos in an addon I author (LiteButtonAuras) and need to be able to iterate the action bar buttons and hook when a new button is created.

Edit: deleted my previous integration here as it was all a waste of time since Dominos was (unknown to me) re-using the Blizzard buttons.

This is my best attempt at peeking at the internals and creating a new integration. Do you have a better suggestion? This is not at all urgent, obviously you are very busy trying to get all this over the line.

function LBA.BarIntegrations:DominosInit()
    if Dominos then
        for actionButton in pairs(Dominos.ActionButtons.buttons) do
            GenericInitButton(actionButton)
        end
        hooksecurefunc(Dominos.ActionBar, 'OnAttachButton', function (bar, button) GenericInitButton(button) end)
    end
end

[Tuller]

This should work:

hooksecurefunc(Dominos.ActionButton, "OnCreate", function(button, id)
    -- do stuff
end)

[mbattersby]

It this a reasonable way to iterate the existing buttons?

        for actionButton in pairs(Dominos.ActionButtons.buttons) do
            -- do stuff
        end

[Tuller]

That’s probably the easiest for the moment. I’ll add a GetAll

[Tuller]

Over the weekend I'll be implementing options to hide the glow, and revert the loss of control cooldown behavior to earlier versions.

[Tuller]

Beta5 implements an option to disable the spell activation glows, and should use an older behavior for loss of control cooldowns.

[hollo6]

I have tested this version and it removes the glows entirely, but I still need to see them, just not in the supernova format. Would it be possible to have an option to use the old ones or let other addons do it?

[Tuller]

I’ve dimmed the glow and dropped the initial flash

[hollo6]

This looks better, although it was too dim for me but looked ok after increasing the alpha manually in SetVertexColor. Any chance this could be a setting? I also miss the proc flash, it should still be a bit more evident when the proc happens.

[hollo6]

Does this mean we're not going to get a solution for this?

[Tuller]

I’ve kept the completely turn off option but I reverted the dimimg of the flash after you and a few others noted it was too hard to see

[hollo6]

How about adding the (old) proc flash? It's still very needed. You could probably copy-paste it from the already existing addons (HideActionBarAnimations did it perfectly).