10.2.9 broke button text

[hollo6]

When reporting an issue, please try to reproduce the issue with just Dominos and Dominos_Config running. Reproduced with everything else disabled.

Addon Version 10.2.9

World of Warcraft Version Retail

Looks the same as in beta1 but this time it happened after upgrading to 10.2.9 and none of the bindings-cache.wtf files were modified so there is no way to restore them either. The bindings are still working but they are not being shown on action bars 2, 8, 10 and 12.

[Tuller]

What version did you upgrade from?

[hollo6]

10.2.1

[hollo6]

I just realized I might not have worded this clearly enough. The binding text is now missing while using the new version. Still exists in 10.2.10.

[Tuller]

I've not yet replicated this one.

[hollo6]

Anythig I can do to help tracking the issue down? I can reproduce it any time by updating to 10.2.9 or 10.2.10 and doing absolutely nothing else.

[Tuller]

Are you seeing it with only Dominos + Dominos_Config enabled?

[hollo6]

Yes.

[hollo6]

Not sure how relevant this is, but it looks exactly the same as the previous issue, but then it happened after rolling back from a beta version to 10.2.1 and I could fix it by restoring the bindings-cache.wtf that beta versions altered during update. But these versions (10.2.9 and 10.2.10) don't alter that file at all.

[Tuller]

What are your bindings in those cases?

[hollo6]

bar 2: F5, F10, DO, SF3 bar 8: S2, S1, S4, S3 bar 10: AWD, AWU, SB5, B5, SE, E, WU, AF1, AF2, SF1 bar 12: A` A1

Unaffected bars have totally similar bindings and combinations so I'm pretty sure that the actual bindings don't matter.

[Tuller]

Were you binding directly to the buttons? That is DominosActionButton?

[hollo6]

Might be onto something there. bind UP MULTIACTIONBAR1BUTTON4 - OK bind DOWN CLICK DominosActionButton16:LeftButton - NOK

But I haven't changed my bindings in a decade.

Edit: just checked my backups and my bindings-cache.wtf was the same 2 years ago - half the bars with original-looking button names and the other half DominosActionButton.

[Tuller]

That may be the issue here. Dominos bindings should use :HOTKEY instead of :LeftButton. Both can work, but only HOTKEY really supports cast on keypress

[hollo6]

But the bindings work, they are just not being shown on the buttons.

[Tuller]

Yes, that makes sense, because I only display the binding associated with the HOTKEY entry. If you run /run Dominos.db.global.bindingsVersion = nil; ReloadUI() then the migration code for global bindings should be run again.

[hollo6]

Right, this did the trick. So the problem here is that this code is not being run in 10.2.9 and 10.2.10. I'm not sure about versions between beta4 and 10.2.8 because those had bigger issues so I haven't checked if bindings-cache.wtf changed, but it did definitely run in beta versions.

[Tuller]

10.2.5 is when I bumped the bindings version number. You reverted your bindings to a prior version, if I recall.

[hollo6]

Yes, I kept rolling back to 10.2.1.