tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
79 stars 27 forks source link

Vehicle bar (for ducks) not showing for Amirdrassil Council raid fight #813

Closed naasfu closed 5 months ago

naasfu commented 5 months ago

During the Council fight, I'm no longer getting the Vehicle UI when Duck'ed during the Council fight. My regular bars are still visible as if the Override Action Bar setting was disabled. I believe this started happening after the 10.2.5 release.

I do get the Duck action bar when we're transformed into ducks before the fight actually begins, so this might be a raid encounter only issue? The issue also doesn't repro when I pick up one of the Loamms during the Loamm dig scenarios.

From looking at comments on CurseForge, MrFIXIT (comment #6311612) might be having the same issue as me.

When reporting an issue, please try to reproduce the issue with just Dominos and Dominos_Config running. Unfortunately this is difficult to repro since I can only repro this during the Council raid fight, and so I can't disable the rest of my addons for this. If there's some other similar vehicle UI behavior in WoW where I can test this on my own, please let me know.

I ran Bugsack and got the following error (see below), but I think this might have triggered earlier (not sure based on the timestamp) on before the Council fight, so it might be unrelated.

Addon Version 10.2.9-retail

World of Warcraft Version Dragonflight retail

1x [ADDON_ACTION_BLOCKED] AddOn 'Dominos' tried to call the protected function 'OverrideActionBarButton4:SetAttribute()'. [string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485> [string "=[C]"]: in function SetAttribute' [string "@FrameXML/ActionButton.lua"]:485: in functionUpdatePressAndHoldAction' [string "@FrameXML/ActionButton.lua"]:551: in function Update' [string "@FrameXML/ActionButton.lua"]:503: in functionUpdateAction' [string "@FrameXML/ActionButton.lua"]:981: in function `OnEvent' [string "@FrameXML/ActionButton.lua"]:207: in function <FrameXML/ActionButton.lua:204>

Locals: Skipped (In Encounter)

naasfu commented 5 months ago

It's possible that the protected function error I included above might be the cause for the issue.

I did Council again today, and the same error triggered again during the intro Ducks vehicle UI before we started the fight. At that point my Duck vehicle UI went crazy and started flipping between the vehicle UI and my regular bars, and I was forced to reload.

However, I think reloading put me back into a good state, because I got the Duck vehicle UI properly during the actual raid fight.

So the above error may be putting things into a bad state.