search

tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
79 stars 27 forks source link

10.2.15 macros disappear from bars #831

Closed hollo6 closed 4 months ago

hollo6 commented 5 months ago

When reporting an issue, please try to reproduce the issue with just Dominos and Dominos_Config running. Reproduced with everything else disabled.

Addon Version 10.2.15-beta1 and 10.2.15 both have this issue.

World of Warcraft Version Retail

Upon changing specialization, and some other events that I couldn't yet identify (probably taking portals but that alone is not a reliable way to reproduce this), macros disappear from action bars and only a blank button is displayed. Can be temporarily "fixed" by grabbing an ability or macro. Mainly action bars 4, 5, 10 and 14 are affected as far as I can see.

Tuller commented 4 months ago

I likely just need to force an icon update on SPELLS_CHANGED.

hollo6 commented 4 months ago

Not sure what changed on this front, this wasn't an issue in previous addon versions. Also I probably didn't describe the problem well enough, the place for the missing macros is almost invisible, I can only see the border around that empty slot because I know to look for it.

Tuller commented 4 months ago

Its a regression from me refactoring the code base a bit.

hollo6 commented 4 months ago

All use cases look good now, thanks!