search

tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
79 stars 27 forks source link

[Cata Classic] Enounter Bar saved location not respected #858

Closed Road-block closed 1 month ago

Road-block commented 1 month ago

When reporting an issue, please try to reproduce the issue with just Dominos and Dominos_Config running. Dominos reuses a good chunk of the stock UI, and other popular addons, like Move Anything, like to take control of those parts, too.

Addon Version You can get this via running /dominos version in game 10.2.30-cata

World of Warcraft Version For example, Classic, Retail, PTR, Beta. Cataclysm Classic

The Encounter Bar (shows Alt PowerBar from what I can tell? for when it shows up) I have saved to a specific location (center bottom closer to my actionbars) The move overlay at that location with /dominos config so it doesn't seem to be a persistence issue.

Unexpected behavior. Regardless where it is saved it pops up at the default location when it shows up during fights.

Road-block commented 1 month ago

I restored a line that was commented out - in my local copy - and that seems to have fixed the issue (alt power bar showed at the saved location on Chogal with corruption mechanic)

The line in question being Dominos/bars/encounterBar.lua#L78

I have no idea if there needs to be conditional code for other client versions as I don't play mainline.

Tuller commented 1 month ago

Thanks. I've put the setting behind a client check because it isn't necessary in retail

kbinz commented 3 weeks ago

The fix doesn't work for me after a death. /rl helps Version 10.2.32

dominos_encounter_bar

Road-block commented 2 weeks ago

I noticed the same after some pull on Atramedes. I don't know if it was due to wipe or Blizzard changed something in one of the recent Cata classic patches.

kbinz commented 2 weeks ago

Also noticed it today while doing dmf dailys

Road-block commented 1 week ago

Also noticed it today while doing dmf dailys

This is real interesting. Which daily shows an alternate power bar. Having a way to troubleshoot outside of a raid would be really helpful.

kbinz commented 1 week ago

Okay sorry for my previous too imprecise describtion. I hope this clearfies it better :)

My Encounter bar is first at the position i defined. After a death in a fight with an encounter bar, the position is in the middle of the screen.

Ways to reproduce I recognized at dmf: Exite the vehicle manually at the tonk challenge, be destroyed or let the timer expire (daily: "Tonk Commander"). Let the timer expire at the shooting range (daily: "He Shoots, He Scores!"). Edit: At the Ring Toss the Encounter bar position is right after you missed all of the throws but the next time only 1 of the bars will be shown.

Tomorow I'll check other dailys there

Cheers!

kbinz commented 1 week ago

tyvm <3 I'll see next week thursday if it fixed the problem =)