tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
79 stars 26 forks source link

The maximum value of rowoffset should be added with the value of Space. #863

Closed WhisperWindE closed 4 months ago

WhisperWindE commented 5 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here. This is the only way to achieve vertical alignment when staggered rows. image

Tuller commented 5 months ago

I never actually considered this particular bar configuration before

WhisperWindE commented 5 months ago
function ButtonBar:SetRowOffset(rowOffset)
    self.sets.rowOffset = rowOffset + self.sets.spacing
    self:Layout()
end

I simply modified the function to temporarily implement this offset but there is a problem, every time I switch to modify, this offset will be automatically added

Which one should I modify correctly?

Tuller commented 5 months ago

I think you want to modify the layout function directly

WhisperWindE commented 5 months ago

Bar-RowOffset range (0-36) 36 is the width of the button How to add the width of Spaceing For example, the default Space=2 The range of offset should be 0----38 (36+2)

Tuller commented 5 months ago

This is implemented now - The min and max values of the slider will include spacing. You can also type in a value to bypass the limits that are in place.

WhisperWindE commented 5 months ago

Which file was changed? I used it WotLK Classic

Tuller commented 5 months ago

I updated Dominos Config’s slider defaults

https://github.com/tullamods/Dominos/commit/08509946a13ffd1d4ccdb3536e68b497cfe79a56